[ET-VK][ez] Apply rotary embedding as Module #6391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context As title. Wrap the `apply_rotary_emb` function call in a `nn.Module` to make it easy to perform a source module replacement for rotary embedding calculation. The Vulkan delegate will use the source module replacement technique to insert a custom op to calculate rotary embeddings. Differential Revision: [D64697589](https://our.internmc.facebook.com/intern/diff/D64697589/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6391
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 4d3230c with merge base 46ea1a4 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64697589 |
This was referenced Oct 21, 2024
junpi3
approved these changes
Oct 21, 2024
## Context As title. Wrap the `apply_rotary_emb` function call in a `nn.Module` to make it easy to perform a source module replacement for rotary embedding calculation. The Vulkan delegate will use the source module replacement technique to insert a custom op to calculate rotary embeddings. Differential Revision: [D64697589](https://our.internmc.facebook.com/intern/diff/D64697589/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D64697589 |
kirklandsign
had a problem deploying
to
cherry-pick-bot
GitHub Actions
Failure
kirklandsign
added a commit
that referenced
this pull request
Oct 21, 2024
Pull Request resolved: #6391 ## Context As title. Wrap the `apply_rotary_emb` function call in a `nn.Module` to make it easy to perform a source module replacement for rotary embedding calculation. The Vulkan delegate will use the source module replacement technique to insert a custom op to calculate rotary embeddings. ghstack-source-id: 249175724 @exported-using-ghexport Differential Revision: [D64697589](https://our.internmc.facebook.com/intern/diff/D64697589/) Co-authored-by: Stephen Jia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
As title. Wrap the
apply_rotary_embfunction call in ann.Moduleto make it easy to perform a source module replacement for rotary embedding calculation.The Vulkan delegate will use the source module replacement technique to insert a custom op to calculate rotary embeddings.
Differential Revision: D64697589